am i doing this right